Define NO_TFO on macOS < 10.11#22
Define NO_TFO on macOS < 10.11#22barracuda156 wants to merge 1 commit intofolkertvanheusden:masterfrom
Conversation
folkertvanheusden
left a comment
folkertvanheusden
left a comment
There was a problem hiding this comment.
I wonder if this could be done in the cmake file?
|
@folkertvanheusden Perhaps, I am just not really sure how to check for macOS version via CMakeLists. |
|
I think it can be done via
https://stackoverflow.com/questions/27660048/cmake-check-if-mac-os-x-use-apple-or-apple
Don't have a mac so can't test it.
…On Thu, Sep 26, 2024 at 9:13 PM Sergey Fedorov ***@***.***> wrote:
@folkertvanheusden <https://github.com/folkertvanheusden> Perhaps, I am
just not really sure how to check for macOS version via CMakeLists.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUN5IW36ERW4UQQLBZIQ3HLZYRMGVAVCNFSM6AAAAABO5N47POVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXG4ZTQMBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, but we do not want to disable it for all macOS altogether. Only for versions prior to 10.11. |
|
There is an interesting discussion about TFO support in different distros/versions/archs: rust-lang/socket2#49 |
|
Checking symbols with CMake: https://cmake.org/cmake/help/latest/module/CheckSymbolExists.html |
3 participants
Closes: #19